This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
refactor: redefine the behavior of SupernodeLocator #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
==========================================
- Coverage 51.41% 51.40% -0.02%
==========================================
Files 125 125
Lines 8240 8241 +1
==========================================
- Hits 4237 4236 -1
- Misses 3660 3661 +1
- Partials 343 344 +1
Continue to review full report at Codecov.
|
* redefine the behavior of method Get: It should return nil before first calling the Next method. * add method Size to return the number of supernodes * fix the implementation of StaticLocator Signed-off-by: lowzj <[email protected]>
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lowzj [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews