Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

refactor: move package dfget/util to pkg/algorithm #1318

Merged
merged 1 commit into from
May 1, 2020

Conversation

lowzj
Copy link
Member

@lowzj lowzj commented Apr 30, 2020

Signed-off-by: lowzj [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lowzj lowzj changed the title refacotr: move package dfget/util to pkg/algorithm refactor: move package dfget/util to pkg/algorithm Apr 30, 2020
@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #1318 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   51.16%   51.16%   -0.01%     
==========================================
  Files         124      123       -1     
  Lines        8175     8177       +2     
==========================================
+ Hits         4183     4184       +1     
  Misses       3654     3654              
- Partials      338      339       +1     
Impacted Files Coverage Δ
cmd/dfdaemon/app/init.go 0.00% <0.00%> (ø)
pkg/algorithm/algorithm.go 80.85% <67.85%> (-19.15%) ⬇️
dfget/core/core.go 45.78% <100.00%> (ø)
supernode/daemon/mgr/scheduler/manager.go 21.91% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc9d86...ce8b258. Read the comment docs.

@starnop
Copy link
Contributor

starnop commented May 1, 2020

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants