Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

test: add unit test case for super_reader.go #1291

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

fenggw-fnst
Copy link
Contributor

Signed-off-by: Guangwen Feng [email protected]

Ⅰ. Describe what this PR did

Add unit test case for super_reader.go

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #1291 into master will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
+ Coverage   49.74%   50.27%   +0.52%     
==========================================
  Files         120      120              
  Lines        7938     7938              
==========================================
+ Hits         3949     3991      +42     
+ Misses       3666     3620      -46     
- Partials      323      327       +4     
Impacted Files Coverage Δ
supernode/daemon/mgr/cdn/cdn_util.go 46.15% <0.00%> (+15.38%) ⬆️
supernode/daemon/mgr/cdn/super_reader.go 70.23% <0.00%> (+47.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4e541...58e82bb. Read the comment docs.


"github.com/dragonflyoss/Dragonfly/pkg/fileutils"

"github.com/dragonflyoss/Dragonfly/supernode/config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a blank line below

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit 4c2af2b into dragonflyoss:master Apr 19, 2020
@fenggw-fnst fenggw-fnst deleted the work branch April 20, 2020 04:07
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants