Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

pkg: add bitmap in pkg #1285

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

wangforthinker
Copy link
Contributor

Signed-off-by: allen.wq [email protected]

Ⅰ. Describe what this PR did

Add bitmap struct.

Ⅱ. Does this pull request fix one issue?

NONE.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Add unit test.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @wangforthinker
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@hhhhsdxxxx
Copy link

hhhhsdxxxx commented Apr 15, 2020

lgtm!
Reviewed-by [email protected]

@wangforthinker wangforthinker force-pushed the feat/add-bitmap branch 2 times, most recently from f4e1a07 to b7fcba0 Compare April 15, 2020 08:53
@xujihui1985
Copy link

lgtm
Reviewed-by [email protected]

pkg/bitmap/bitmap.go Outdated Show resolved Hide resolved
@wangforthinker wangforthinker force-pushed the feat/add-bitmap branch 4 times, most recently from fe8fb9f to 5ee51a2 Compare April 16, 2020 05:26
@allencloud allencloud changed the title add bitmap in pkg pkg: add bitmap in pkg Apr 16, 2020
@allencloud
Copy link
Contributor

Thanks for the review, @hhhhsdxxxx @xujihui1985
Could you help to pay another review here? @lowzj Thanks

@wangforthinker wangforthinker force-pushed the feat/add-bitmap branch 3 times, most recently from 110a150 to 606e589 Compare April 21, 2020 05:59
pkg/bitmap/bitmap.go Outdated Show resolved Hide resolved
Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit 7aa7efc into dragonflyoss:master Apr 22, 2020
@wangforthinker wangforthinker deleted the feat/add-bitmap branch April 23, 2020 03:18
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants