feature: define api types for seed pattern #1270

wangforthinker · 2020-04-07T12:36:36Z

Signed-off-by: allen.wq [email protected]

Ⅰ. Describe what this PR did

define some api types for seed mode.

Ⅱ. Does this pull request fix one issue?

NONE.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

none.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

lowzj

The codes in apis/types will be generated automatically by the robot, it's better not to submit these codes in pr.

ignore this, it's hard to separate them.

lowzj · 2020-04-07T14:15:10Z

apis/swagger.yml

+      basic:
+        $ref: "#/definitions/PeerInfo"
+        description: "Basic node info"
+      extra:


I think the extra property is a map struct not a pre-defined object, thus we can add some customized properties without changing the api in the future.

allencloud · 2020-04-08T05:34:14Z

apis/swagger.yml

@@ -1362,6 +1394,93 @@ definitions:
        format: "int64"
        description: "The length of the file dfget requests to download in bytes."

+  NetworkInfoFetchRequest:
+    type: "object"
+    description: ""


Please add description here.

allencloud · 2020-04-08T05:34:26Z

apis/swagger.yml

+
+  Extra:
+    type: "object"
+    description: ""


Please add description here.

allencloud · 2020-04-08T05:34:37Z

apis/swagger.yml

+
+  TaskFetchInfo:
+    type: "object"
+    description: ""


Please add description here.

allencloud · 2020-04-08T05:34:44Z

apis/swagger.yml

+
+  Node:
+    type: "object"
+    description: ""


Please add description here.

allencloud · 2020-04-08T05:37:00Z

apis/swagger.yml

+          This attribute represents the length of resource, dfdaemon or dfget catches and calculates
+          this parameter from the headers of request URL. If fileLength is vaild, the supernode need
+          not get the length of resource by accessing the rawURL.
+          format: "int64"


Maybe the indent here is incorrect.

allencloud · 2020-04-08T05:38:57Z

apis/swagger.yml

+      IP:
+        type: "string"
+        description: "IP address which peer client carries"
+        format: "string"


Please use ipv4 or ipv6 for the format here.

allencloud · 2020-04-08T05:41:28Z

apis/swagger.yml

+        items:
+          $ref: "#/definitions/Node"
+
+  HeartBeatRequest:


This struct is newly declared here, while where to use it in the API endpoint?
I think where to use it is missing in the API defining side.

lowzj · 2020-04-08T07:33:35Z

apis/types/task_register_request.go:110:28: "specfic" is a misspelling of "specific"
apis/swagger.yml:799:34: "specfic" is a misspelling of "specific"
apis/types/task_register_request.go:110:28: "specfic" is a misspelling of "specific"
apis/types/task_register_request.go:110:28: "specfic" is a misspelling of "specific"
./apis/types/task_register_request.go:110:28: "specfic" is a misspelling of "specific"
apis/swagger.yml:799:34: "specfic" is a misspelling of "specific"
./apis/swagger.yml:799:34: "specfic" is a misspelling of "specific"

please resolve these spell errors

codecov-io · 2020-04-09T02:35:30Z

Codecov Report

Merging #1270 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   48.51%   48.51%           
=======================================
  Files         121      121           
  Lines        7788     7788           
=======================================
  Hits         3778     3778           
  Misses       3698     3698           
  Partials      312      312

Impacted Files	Coverage Δ
dfget/types/register_request.go	`0.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4e7b0...1d160be. Read the comment docs.

lowzj · 2020-04-09T02:42:23Z

apis/types/extra.go

+
+// Extra extra
+// swagger:model Extra
+type Extra struct {


This file is not generated by go-swagger with the current api definition.

Signed-off-by: allen.wq <[email protected]>

lowzj

LGTM

allencloud · 2020-04-10T09:04:53Z

apis/swagger.yml

@@ -648,6 +648,47 @@ paths:
        500:
          $ref: "#/responses/500ErrorResponse"

+  /peer/heartbeat:
+    get:


I do not think this is a "GET" request. Maybe POST is better. @wangforthinker

Signed-off-by: Gaius <[email protected]>

pouchrobot added the size/XXL label Apr 7, 2020

lowzj reviewed Apr 7, 2020

View reviewed changes

allencloud assigned lowzj and starnop Apr 8, 2020

allencloud added the areas/api label Apr 8, 2020

allencloud reviewed Apr 8, 2020

View reviewed changes

wangforthinker force-pushed the feat/define-some-api-types-prepare-pr branch 2 times, most recently from a8f34df to ffd954f Compare April 9, 2020 02:31

lowzj reviewed Apr 9, 2020

View reviewed changes

define some api types.

1d160be

Signed-off-by: allen.wq <[email protected]>

wangforthinker force-pushed the feat/define-some-api-types-prepare-pr branch from ffd954f to 1d160be Compare April 9, 2020 02:48

lowzj changed the title ~~define some api types.~~ feature: define api types for seed pattern Apr 9, 2020

pouchrobot added the kind/feature label Apr 9, 2020

lowzj reviewed Apr 9, 2020

View reviewed changes

lowzj merged commit 05b2f8e into dragonflyoss:master Apr 9, 2020

pouchrobot mentioned this pull request Apr 10, 2020

WeeklyReport of Dragonfly from 2020-04-03 to 2020-04-10 #1276

Closed

allencloud reviewed Apr 10, 2020

View reviewed changes

wangforthinker deleted the feat/define-some-api-types-prepare-pr branch April 23, 2020 03:18

sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022

test: fix storage backups (dragonflyoss#1270)

5efaf23

Signed-off-by: Gaius <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: define api types for seed pattern #1270

feature: define api types for seed pattern #1270

wangforthinker commented Apr 7, 2020

lowzj left a comment •

edited

Loading

lowzj Apr 7, 2020

wangforthinker Apr 9, 2020

allencloud Apr 8, 2020

wangforthinker Apr 9, 2020

allencloud Apr 8, 2020

wangforthinker Apr 9, 2020

allencloud Apr 8, 2020

wangforthinker Apr 9, 2020

allencloud Apr 8, 2020

wangforthinker Apr 9, 2020

allencloud Apr 8, 2020

wangforthinker Apr 9, 2020

allencloud Apr 8, 2020

wangforthinker Apr 9, 2020

allencloud Apr 8, 2020

wangforthinker Apr 9, 2020

lowzj commented Apr 8, 2020

codecov-io commented Apr 9, 2020 •

edited

Loading

lowzj Apr 9, 2020

wangforthinker Apr 9, 2020

lowzj left a comment

allencloud Apr 10, 2020

feature: define api types for seed pattern #1270

feature: define api types for seed pattern #1270

Conversation

wangforthinker commented Apr 7, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

lowzj left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lowzj commented Apr 8, 2020

codecov-io commented Apr 9, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lowzj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lowzj left a comment •

edited

Loading

codecov-io commented Apr 9, 2020 •

edited

Loading