Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

add unit test for GetMsgByCode #1179

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

zhouhao3
Copy link
Contributor

Signed-off-by: Zhou Hao [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Dragonfly, @q384566678
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

codecov-io commented Jan 14, 2020

Codecov Report

Merging #1179 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1179      +/-   ##
=========================================
+ Coverage   47.47%   47.6%   +0.12%     
=========================================
  Files         113     114       +1     
  Lines        7193    7212      +19     
=========================================
+ Hits         3415    3433      +18     
- Misses       3505    3506       +1     
  Partials      273     273
Impacted Files Coverage Δ
pkg/constants/dfget_super_code.go 94.73% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da94e78...41ab743. Read the comment docs.

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit 4b07fc0 into dragonflyoss:master Jan 14, 2020
@zhouhao3 zhouhao3 deleted the add-dfget-test branch January 14, 2020 12:12
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants