Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

bugfix: disable displaying auto generation tag in cli docs for supernode #1102

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Nov 29, 2019

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

The generated doc of supernode by spf13/cobra will display auto-generation tag in cli docs which like this

Auto generated by spf13/cobra on 29-Nov-2019

We should disable it.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Nov 29, 2019
@codecov-io
Copy link

Codecov Report

Merging #1102 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1102   +/-   ##
=======================================
  Coverage   47.23%   47.23%           
=======================================
  Files         116      116           
  Lines        7203     7203           
=======================================
  Hits         3402     3402           
  Misses       3533     3533           
  Partials      268      268
Impacted Files Coverage Δ
cmd/supernode/app/root.go 69.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ecf02...6307135. Read the comment docs.

Copy link
Collaborator

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit b1a405c into dragonflyoss:master Nov 30, 2019
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
bugfix: disable displaying auto generation tag in cli docs for supernode
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
* feat: optimize depth limit func (dragonflyoss#1099)

Signed-off-by: Gaius <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This is bug report for project size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants