Merge pull request #707 from cd1989/bash-scripts-options

Add options for bash scripts

hack/after-install.sh

@@ -1,4 +1,8 @@
 #!/bin/bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 ln -s /opt/dragonfly/df-client/dfget /usr/local/bin/dfget
 ln -s /opt/dragonfly/df-client/dfdaemon /usr/local/bin/dfdaemon

hack/before-remove.sh

@@ -1,4 +1,8 @@
 #!/bin/bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 rm -f /usr/local/bin/dfget
 rm -f /usr/local/bin/dfdaemon

hack/build.sh

@@ -1,4 +1,9 @@
 #!/bin/bash
+
+set -o nounset
+set -o errexit
+set -o pipefail
+
 DFDAEMON_BINARY_NAME=dfdaemon
 DFGET_BINARY_NAME=dfget
 SUPERNODE_BINARY_NAME=supernode
@@ -100,7 +105,7 @@ main() {
         esac
     else
         echo "Begin to build in the local environment."
-        case "$1" in
+        case "${1-}" in
             dfdaemon)
                 build-dfdaemon-local
             ;;

hack/check-docker.sh

@@ -1,4 +1,9 @@
 #!/bin/bash
+
+set -o nounset
+set -o errexit
+set -o pipefail
+
 check() {
     which docker > /dev/null && docker ps > /dev/null 2>&1
     if [[ $? != 0 ]]; then

hack/check.sh

@@ -1,4 +1,9 @@
 #!/bin/bash
+
+set -o nounset
+set -o errexit
+set -o pipefail
+
 curDir=$(cd "$(dirname "$0")" && pwd)
 cd "${curDir}/../" || return
 

hack/docker-build.sh

@@ -1,5 +1,9 @@
 #!/bin/bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 DF_VERSION=${DF_VERSION:-"latest"}
 curDir=$(cd "$(dirname "$0")" && pwd)
 cd "${curDir}/../" || return
@@ -13,7 +17,7 @@ docker-build::build-supernode(){
 }
 
 main() {
-    case "$1" in
+    case "${1-}" in
         dfclient)
             docker-build::build-dfclient
         ;;

hack/env.sh

@@ -13,6 +13,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 export INSTALL_HOME=/opt/dragonfly
 export INSTALL_CLIENT_PATH=df-client
 export INSTALL_SUPERNODE_PATH=df-supernode

hack/generate-contributors.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e
+
+set -o nounset
+set -o errexit
+set -o pipefail
 
 # see also ".mailmap" for how email addresses and names are deduplicated
 

hack/generate-docs.sh

@@ -1,5 +1,9 @@
 #!/bin/bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 curDir=$(cd "$(dirname "$0")" && pwd)
 cd "${curDir}" || return
 
@@ -17,7 +21,7 @@ generate-cli-docs(){
 }
 
 main () {
-    case "$1" in
+    case "${1-}" in
         cli)
             generate-cli-docs
         ;;

hack/generate-super-mock-mgr.sh

@@ -1,5 +1,8 @@
 #!/bin/bash
-set -e
+
+set -o nounset
+set -o errexit
+set -o pipefail
 
 # This script is used to generate mock files for interfaces.
 

hack/generate-swagger-models.sh

@@ -1,5 +1,9 @@
 #!/bin/bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 # Here is details of the swagger binary we use.
 # $ swagger version
 # version: 0.19.0

hack/install.sh

@@ -1,4 +1,9 @@
 #!/bin/bash
+
+set -o nounset
+set -o errexit
+set -o pipefail
+
 BIN_DIR="../bin"
 DFDAEMON_BINARY_NAME=dfdaemon
 DFGET_BINARY_NAME=dfget

hack/package.sh

@@ -1,5 +1,9 @@
 #!/bin/bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 USE_DOCKER=${USE_DOCKER:-"0"}
 VERSION=${VERSION:-"0.0.$(date +%s)"}
 

hack/start-supernode.sh

@@ -1,5 +1,9 @@
 #!/usr/bin/env bash
 
+set -o nounset
+set -o errexit
+set -o pipefail
+
 nginx
 
 /opt/dragonfly/df-supernode/supernode "$@"

hack/unit-test.sh

@@ -1,4 +1,9 @@
 #!/bin/bash
+
+set -o nounset
+set -o errexit
+set -o pipefail
+
 curDir=$(cd "$(dirname "$0")" && pwd)
 cd "${curDir}" || return