feat(contrib/helm): evaluate the provided passwordSecretName value as a template #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a template
Useful to reuse some defined variables or functions directly to compute the value
(external chart for instance, that depends on this one)
example:
'{{ include "something.defined.elsewhere" $ }}-secrets'
Signed-off-by: Raphael Glon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to reuse some defined variables or functions directly to compute the value (external chart for instance, that depends on this one)
example:
'{{ include "something.defined.elsewhere" $ }}-secrets'
Reference:
like done here for redis
https://github.com/bitnami/charts/blob/7eb2f519f77638c5e1b60aa62f3d3fa2f4cddbe8/bitnami/redis/templates/_helpers.tpl#L208
Drawback: unsanitized/user provided code injection, in the unlikely event where this chart is used by some with untrusted user input values (not sure who would do this but just want to mention this cornercase)