Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: print info stats if test_noreply_pipeline fails #4016

Merged
merged 1 commit into from
Oct 30, 2024
Merged

chore: print info stats if test_noreply_pipeline fails #4016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/dragonfly/pymemcached_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import socket
import random
import time
import warnings

from . import dfly_args
from .instance import DflyInstance
Expand Down Expand Up @@ -67,7 +68,9 @@ def test_noreply_pipeline(df_server: DflyInstance, memcached_client: MCClient):
assert memcached_client.get_many(keys) == {k: v.encode() for k, v in zip(keys, values)}

info = Redis(port=df_server.port).info()
assert info["total_pipelined_commands"] > 0 # sometimes CI is slow
if info["total_pipelined_commands"] == 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also bump up the range slightly ? It's 2k on line 59, can you plz try 4 or 8 k?

warnings.warn("No pipelined commands were detected. Info: \n" + str(info))
assert False, "No pipelined commands were detected."


@dfly_args(DEFAULT_ARGS)
Expand Down
Loading