Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workflow): changes default permissions to read for few workflows increasing security #3905

Merged
merged 10 commits into from
Oct 26, 2024

Conversation

BLANKatGITHUB
Copy link
Contributor

well sorry for trouble, I just add all the changes related to workflows in this one pr, I will make separate pr to add new workflows.
I accidentally deleted my main branch closing previous pr , I hope you can over look it this time I am kinda new , It wont happen again.

@BLANKatGITHUB
Copy link
Contributor Author

@romange I cant run workflows if this repo has restriction for new contributors to run workflow on their public repo can you please allow me to do that.

@romange
Copy link
Collaborator

romange commented Oct 24, 2024

@BLANKatGITHUB hello. are you planning to work on this PR?

@BLANKatGITHUB
Copy link
Contributor Author

umm sure
but for some reason I can't run and test workflows in my branch for reason , but you can commit these changes which does not affect the workflows directly , I will add the other workflows later when I get permission to run workflow in my branch.

@romange
Copy link
Collaborator

romange commented Oct 26, 2024

Thanks!

@romange romange merged commit 851e432 into dragonflydb:main Oct 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants