-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add lua modules #273
Conversation
I've chosen to embed the module sources at
I guess, a single target with a single build file at |
Looks good.
|
I've fixed the registration process, because lua 5.2 changed the way modules are registered. ( The modules show quite a lot of warnings (about 20) during compile (mainly sign-compare, implicit-fallthrough, misleading-identation). Should I fix them or just suppress them in the sub-build? |
just opress them - see target_compile_options in redis CMakeLists |
do you mind squashing the commits into a single one? |
0094207
to
8e5bdf1
Compare
1495aee
to
772f6d4
Compare
forgot to pull my merge 😓 |
Add the following modules to the lua interpreter:
and registers them in the globals table.
Helps with #184