fix: increase lua stack limit to 8KB (#3080)

Before that 'lua_checkstack(lua(), 7000)' would not pass because we limited lua stack to 4KB. 7000 is the max limit used by bullmq, so we raising it to support this case. Signed-off-by: Roman Gershman <[email protected]>
dragonflydb · May 25, 2024 · 20c98c2 · 20c98c2
1 parent fd5ece0
commit 20c98c2
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 49 deletions.
diff --git a/patches/lua-v5.4.4.patch b/patches/lua-v5.4.4.patch
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -8,7 +8,7 @@ endif()
 add_third_party(
   lua
   GIT_REPOSITORY https://github.com/dragonflydb/lua
-  GIT_TAG Dragonfly-5.4.6
+  GIT_TAG Dragonfly-5.4.6a
   CONFIGURE_COMMAND echo
   BUILD_IN_SOURCE 1
   BUILD_COMMAND ${DFLY_TOOLS_MAKE} all

diff --git a/src/core/interpreter_test.cc b/src/core/interpreter_test.cc
@@ -89,6 +89,7 @@ class InterpreterTest : public ::testing::Test {
 
   void SetGlobalArray(const char* name, const vector<string_view>& vec);
 
+  // returns true if script run successfully.
   bool Execute(string_view script);
 
   Interpreter intptr_;
@@ -492,4 +493,25 @@ TEST_F(InterpreterTest, Robust) {
   EXPECT_EQ("", ser_.res);
 }
 
+TEST_F(InterpreterTest, Unpack) {
+  auto cb = [](Interpreter::CallArgs ca) {
+    auto* reply = ca.translator;
+    reply->OnInt(1);
+  };
+  intptr_.SetRedisFunc(cb);
+  ASSERT_TRUE(lua_checkstack(lua(), 7000));
+  bool res = Execute(R"(
+local N = 7000
+
+local stringTable = {}
+for i = 1, N do
+    stringTable[i] = "String " .. i
+end
+  return redis.pcall('func', unpack(stringTable))
+)");
+
+  ASSERT_TRUE(res) << error_;
+  EXPECT_EQ("i(1)", ser_.res);
+}
+
 }  // namespace dfly