Enable progress reporting for ios. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the SimpleSessionExporter to expose a progress Float value. This Float value defaults to 0 if there is no exportSession. A new exportSession private var was added to store the current exportSession. The AVAssetExportSession completion handler updates the exportSession reference to nil once it has completed. To actually send the updates, we add a schedule job every 250 milliseconds which calls our progressHandler. The exporter completion handler cancels it when it is done.
|
Thanks @nvahalik Merged and version v5.0.3 released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the SimpleSessionExporter to expose a progress Float value. This Float value defaults to 0 if there is no exportSession. A new exportSession private var was added to store the current exportSession. The AVAssetExportSession completion handler updates the exportSession reference to nil once it has completed.
To actually send the updates, we add a schedule job every 250 milliseconds which calls our progressHandler. The exporter completion handler cancels it when it is done.
This PR aims to address issue #10