Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 1 if binary requirements are not met #2434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return 1 if binary requirements are not met #2434

wants to merge 2 commits into from

Conversation

aafeijoo-suse
Copy link
Member

This PR fixes the requirements for the caps and plymouth modules.

The dasd_mod module has the same error, but it's RH specific and apparently the binary requirements could be dropped.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@github-actions github-actions bot added modules Issue tracker for all modules caps Issues related to the caps module plymouth Issues related to the plymouth module labels Jul 18, 2023
@LaszloGombos LaszloGombos added the bug Our bugs label Jul 18, 2023
@LaszloGombos LaszloGombos added this to the dracut-060 milestone Jul 18, 2023
@LaszloGombos LaszloGombos modified the milestones: dracut-060, dracut-061 Oct 30, 2023
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
@dracutng dracutng mentioned this pull request Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloGombos LaszloGombos LaszloGombos approved these changes

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

@johannbg johannbg Awaiting requested review from johannbg johannbg is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Our bugs caps Issues related to the caps module modules Issue tracker for all modules plymouth Issues related to the plymouth module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aafeijoo-suse @LaszloGombos