-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(net-lib): add a new dracut module called net-lib #2250
Conversation
96bfb11
to
92f280d
Compare
5ec7b45
to
b87dcbc
Compare
Before PR (net-lib.sh is NOT included)
After PR (net-lib.sh is included)
networking tests are all passing (without changing the tests itself, which is a good indication for maintaining compatibility) |
@aafeijoo-suse do you have any questions or concerns regarding this PR ? |
347e780
to
bee6d1f
Compare
@aafeijoo-suse if you have time, can you please help and check if your concerns are resolved on this PR. Thank you ! |
My main concern is how many setups will break with this change, I thought that you wanted to be conservative. Just doing a quick search on GitHub:
|
Valid concern indeed. I still prefer to be conservative. #2314 is changing the dracut module interface, this PR does not. I started documenting different aspects of compatibility here: https://github.com/dracutdevs/dracut/wiki/Dracut-development#compatibility . This is best example. From a quick look of it, it seems this module needs to change, BUT after the one-time change it seems that this out-of-tree module can just depend on this newly created net-lib instead of cherry-picking a single file from the network module that has no compatibility promise. We should work with this project if possible, but we should not have any kind of compatibility promise for projects picking single files from random directories. This is not even a proper dracut module, it is just a shell script. Same. Not a dracut module. This is packaging file. Irrelevant. As next step I will reach out to bootengine and see if I can get some feedback from them on this PR (instead of me guessing what they think). |
Based on discussion at flatcar/bootengine#69 it does not look like there is opposition for this change. |
From @Mrfai
|
Motivations:
module-setup.sh
files as it has been also pointed out during earlier PR reviews and discussions.dracut -m network-manager
produces a broken initramfs that this PR fixes.Checklist
Fixes #2195