Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3 follow color spec #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue 3 follow color spec #6

wants to merge 2 commits into from

Conversation

clach04
Copy link

@clach04 clach04 commented Sep 15, 2024

No description provided.

@clach04
Fix dracula#4 remove non-colors, also document with hex RGB and comments
8ea99f1
@clach04
Fix issue dracula#3 - colors not following spec
a68e3a8 
https://spec.draculatheme.com/#sec-ANSI colors were not being used.
Re-created from scratch using spec.

NOTE for cursor and bold background used existing fg/bg colors which is
what the Alacritty theme also does. See
https://github.com/dracula/alacritty/blob/master/dracula.toml
9ae0fde from 2023-09-25.
@clach04
Copy link
Author

clach04 commented Sep 15, 2024

Reviewers notes:

  1. This follows on from Fix #4 remove non-colors, also document with hex RGB and comments #5 - recommend merging that first.
  2. This is a complete implementation to follow the spec.
  3. Cursor color may need review, but this is minor in comparison to the problematic colors previously present.

Sample output:

image

This was referenced Sep 15, 2024
Open
Open
@clach04
Copy link
Author

clach04 commented Sep 15, 2024

Manually compared against https://github.com/dracula/pywal/commits/master/dracula.json and it matches exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clach04