fix for issue OPTIONS parsing issue #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should fix the issue reported in 112. The issue with the OPTIONS request is that there is a carriage return on the last line, which makes the loop here go one more time with empty data, which causes
rto be undefined and the whole function returns undefined.You'll notice I added the OPTIONS header as a plain variable in the test, but we will need to do is add the extra carriage return OPTIONS to the sip-message-examples repo to get the test passing correctly for the current setup. I already made a pull request for that davehorton/sip-message-examples#3. Once that is merged, I can update the test so it uses the message from sip-message-examples.