Skip to content

Commit

Permalink
Break not continue
Browse files Browse the repository at this point in the history
  • Loading branch information
dpslwk committed Jan 2, 2020
1 parent 72df623 commit 84cb2e9
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All Notable changes to `ViMbAdminClient` will be documented in this file.

Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) principles.

## 1.1.1 (released 2020-01-02)

### Fixed
- break not continue

## 1.1.0 (released 2019-12-21)

### Added
Expand Down
4 changes: 2 additions & 2 deletions src/Serializer/Normalizer/ViMbAdminNormalizer.php
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public function denormalize($data, $class, $format = null, array $context = [])
case 'links':
// create a new Link object and add it to the $object if its not an array object
if ( ! $object) {
continue;
break;
}
$link = new Link();
foreach ($value as $key => $_value) {
Expand Down Expand Up @@ -186,7 +186,7 @@ public function denormalize($data, $class, $format = null, array $context = [])
$relationships = $relations['data'];
}
if ( ! $relationships) {
continue;
break;
}

foreach ($relationships as $relation) {
Expand Down
4 changes: 2 additions & 2 deletions src/ViMbAdminClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ class ViMbAdminClient
public function __construct(
TokenStore $tokenStore,
\Illuminate\Config\Repository $config,
ViMbAdminNormalizer $normalizer)
{
ViMbAdminNormalizer $normalizer
) {
$this->tokenStore = $tokenStore;
// TODO: strip traling / from url
$this->apiUrl = $config->get('vimbadmin.api_url');
Expand Down

0 comments on commit 84cb2e9

Please sign in to comment.