feat: add inputs for specifiable config #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
added a commit
to kachick/ruby-ulid
that referenced
this pull request
Jan 24, 2023
kachick
added a commit
to kachick/ruby-ulid
that referenced
this pull request
Jan 24, 2023
dsherret
reviewed
Jan 24, 2023
dsherret
reviewed
Jan 24, 2023
dsherret
reviewed
Jan 24, 2023
dsherret
approved these changes
Jan 24, 2023
|
Thank you for improving a few things that I could not decide which way to go! (if syntax, require bool, input name, copying config file as a fixture, etc) 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I would like to have another config between editor integration and CI.
Because I'm using https://github.com/dprint/dprint-plugin-exec to hook other formatters in vscode.
However, as far I I know https://github.com/dprint/dprint-vscode cannot specify another config in the same directory structure.
So...
dprint.jsonin vscode for now.dprint.jsonindprint/check. # This PRdprint-editor.jsonin the vscode integration.I didn't have confidence for...
Added an old version test to the CI to make sure this change does not break current usage.
But 0.14.0 or earlier didn't work with the current dprint.json, even without adding this change.