rollover correlation id. addresses #344 #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be assigned to it. addresses dpkp#344
|
looks great -- can you add a test ? |
| @@ -52,7 +52,7 @@ def _encode_message_header(cls, client_id, correlation_id, request_key): | |||
| """ | |||
| Encode the common request envelope | |||
| """ | |||
| return struct.pack('>hhih%ds' % len(client_id), | |||
| return struct.pack('>hhIh%ds' % len(client_id), | |||
There was a problem hiding this comment.
the kafka protocol defines this field as a signed int32. i think it's better to stick with that.
|
take a look at pr #355 |
|
merged #355 -- thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the correlation id hits 2,147,483,648 (one over int32 MAX), then the driver can't encode that message, and hits an error.
So in this changed I've done two things.
Not sure if this is the better design choice than just doing a check of itertools.count to see if it hit the intmax, then resetting it.