Upgrade vendored six to 1.16.0 to fix Python 3.10 compatibility #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpkp: can you merge this PR and cut a release? |
|
hello! I think I've run into this issue on Python 3.10 :( is it possible to merge this PR and publish a new version? 🙏 |
jeffwidman
reviewed
Feb 6, 2023
Comment on lines
-75
to
-78
| # Don't del it here, cause with gc disabled this "leaks" to garbage. | ||
| # Note: This is a kafka-python customization, details at: | ||
| # https://github.com/dpkp/kafka-python/pull/979#discussion_r100403389 | ||
| # del X |
There was a problem hiding this comment.
Why drop this customization?
|
No longer necessary, since #2398 has been merged. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #2282
Also fixes a problem where
pytestinitialization fails in Python 3.10 if any tests usekafka-python.This change is