Issue #1780 - Consumer hang indefinitely in fetcher._retrieve_offsets() due to topic deletion while rebalancing #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nudge @dpkp can you take a look? |
|
Apologies for not merging this sooner. I'm going to include this PR in 1.4.7. Please note that w/o test coverage, we may end up breaking this functionality in a later release! This section of the codebase (retrieving offsets) has been refactored upstream, and I suspect we may migrate in that direction at some point. |
|
thanks @dpkp, as mentioned in the original issue, I will get into looking at the refactor to match Java client 2.x eventually. Just got my hands full atm. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed scenario in #1780 .
The scenario can also trigger another edge case I bumped into while testing which is
ValueErrorexception fromsubscription_state.assign_from_subscribed()This PR also handles this case by catching the exception and requesting a rejoin.
This change is