Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify these timeouts are in descending order on KafkaConsumer instantiation #1680

Closed
jeffwidman opened this issue Dec 19, 2018 · 1 comment
Closed

Verify these timeouts are in descending order on KafkaConsumer instantiation #1680

jeffwidman opened this issue Dec 19, 2018 · 1 comment

Comments

@jeffwidman
Copy link
Collaborator

When we create a KafkaConsumer, we should validate that the following timeouts are in descending order:

  1. connections_max_idle_ms
  2. request_timeout_ms
  3. session_timeout_ms (or equivalent, depending on pre/post 0.10.1 broker)

If they are not, then raise an error... otherwise the consumer can end up in weird states.
@tvoinarovskyi
Copy link
Collaborator

Sounds reasonable. I wonder does Java client do that, never saw it in the code...

jeffwidman added a commit that referenced this issue Jan 3, 2019
@jeffwidman
Error if connections_max_idle_ms not larger than request_timeout_ms
a5c40c8 
`connections_max_idle_ms` must always be larger than `request_timeout_ms`
to avoid potentially unexpected behavior.

Fix #1680.
@jeffwidman jeffwidman mentioned this issue Jan 3, 2019
Merged
jeffwidman added a commit that referenced this issue Jan 4, 2019
@jeffwidman
Error if connections_max_idle_ms not larger than request_timeout_ms
94595b8 
`connections_max_idle_ms` must always be larger than `request_timeout_ms`
to avoid potentially unexpected behavior.

Fix #1680.
jeffwidman added a commit that referenced this issue Jan 4, 2019
@jeffwidman
Error if connections_max_idle_ms not larger than request_timeout_ms
51c0dd4 
`connections_max_idle_ms` must always be larger than `request_timeout_ms`
to avoid potentially unexpected behavior.

Fix #1680.
jeffwidman added a commit that referenced this issue Mar 14, 2019
@jeffwidman
Error if connections_max_idle_ms not larger than request_timeout_ms
fe8f61f 
`connections_max_idle_ms` must always be larger than `request_timeout_ms`
to avoid potentially unexpected behavior.

Fix #1680.
jeffwidman added a commit that referenced this issue Mar 14, 2019
@jeffwidman
Error if connections_max_idle_ms not larger than request_timeout_ms
b13bcf5 
`connections_max_idle_ms` must always be larger than `request_timeout_ms`
to avoid potentially unexpected behavior.

Fix #1680.
jeffwidman added a commit that referenced this issue Mar 14, 2019
@jeffwidman
Error if connections_max_idle_ms not larger than request_timeout_ms
9433abf 
`connections_max_idle_ms` must always be larger than `request_timeout_ms`
to avoid potentially unexpected behavior.

Fix #1680.
jeffwidman added a commit that referenced this issue Mar 14, 2019
@jeffwidman
Error if connections_max_idle_ms not larger than request_timeout_ms
5954189 
`connections_max_idle_ms` must always be larger than `request_timeout_ms`
to avoid potentially unexpected behavior.

Fix #1680.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffwidman @tvoinarovskyi