fix: rate limiter key function #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 22, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 22, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1. (cherry picked from commit 84ff10b)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1. (cherry picked from commit 84ff10b)
kaxil
pushed a commit
to apache/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1. (cherry picked from commit 84ff10b)
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
utkarsharma2
pushed a commit
to apache/airflow
that referenced
this pull request
Oct 24, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1. (cherry picked from commit 84ff10b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
flask-limiter will not obey to
RATELIMIT_KEY_FUNC, this PR makes it possible to set this configADDITIONAL INFORMATION