Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update jsonschema pip package #1782

Merged
merged 7 commits into from
Jan 12, 2022
Merged

chore: update jsonschema pip package #1782

merged 7 commits into from
Jan 12, 2022

Conversation

hughhhh
Copy link
Contributor

@hughhhh hughhhh commented Jan 10, 2022 •
edited
Loading

Description

Updating jsonschema upgrade to allow for apache/superset to upgrade aiohttps >= 3.7.5

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@hughhhh hughhhh changed the title Update jsonschema pip package chore: update jsonschema pip package Jan 10, 2022
dpgaspar
dpgaspar reviewed Jan 10, 2022
View reviewed changes
setup.py Outdated
@@ -58,7 +58,7 @@ def desc():
"Flask-SQLAlchemy>=2.4, <3",
"Flask-WTF>=0.14.2, <0.15.0",
"Flask-JWT-Extended>=3.18, <4",
"jsonschema>=3.0.1, <4",
"jsonschema==4.0.0", # pinning version for now
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not pin this, since FAB is a base package, do something like ">=3.0.1, <5", so we don't automaticaly included not tested major breaking changes

@hughhhh hughhhh force-pushed the up-jsonschema branch 3 times, most recently from 86bb7ef to 6b4c0a9 Compare January 12, 2022 18:46
@dpgaspar dpgaspar merged commit 557249f into dpgaspar:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughhhh @dpgaspar