Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jQuery to 3.5 (re: #1350) #1351

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Bump jQuery to 3.5 (re: #1350) #1351

merged 1 commit into from
Apr 21, 2020

Conversation

ryw
Copy link
Contributor

@ryw ryw commented Apr 19, 2020

re: #1350

Not sure how to dev FAB locally, if you can give me a quick overview, or point me to a guide, I'm happy to test jQuery 3.5 and try to troubleshoot any issues that arise from bumping it.

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and looks good

@ryw
Copy link
Contributor Author

ryw commented Apr 20, 2020

Great - what do you think about merging and releasing 2.3.3?

@dpgaspar dpgaspar merged commit 7e0cf44 into dpgaspar:master Apr 21, 2020
@dpgaspar
Copy link
Owner

@ryw published 2.3.3rc1 on Pypi: https://pypi.org/project/Flask-AppBuilder/#history

Going to run tests on superset, should be easy to test it on Airflow also.
If all is good final version should be out this week

@dpgaspar
Copy link
Owner

rc1 had a bug not related to this, just pushed 2.3.3rc2

@dpgaspar
Copy link
Owner

dpgaspar commented Apr 24, 2020

Tested on superset and looks good, have you had to time to test on Airflow?

This is ready to go
#1359

dpgaspar added a commit that referenced this pull request Apr 29, 2020
dpgaspar added a commit that referenced this pull request Apr 29, 2020
@dpgaspar dpgaspar mentioned this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants