-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Authlib
requirement to allow version 1.0.1
#1861
Comments
@dpgaspar thoughts on this? |
Ah. Cool yhanks for that. I will update it. Actually the setup.py entry is wrong in a different way. We should use "flask-app-builder[oauth]" as dependency there so that we do not have to manually sync dependencies when FAB updates it. BTW. We have just started to migrate to FAB 4.0 @thesuperzapper - you might want to join our crew of people who will help with testing it (there are many breaking changes in the underlying libraries). I've added you so to that you are aware and possibly help us with testing Airfflow apache/airflow#22397 (comment) In the meantime - indeed upgrading of the authlib in FAB 4.1.2 might be a good idea indeed (and once we use oauth extra, airflow deps will update automatically) |
I'll open a PR to bump and test authlib |
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861
Also @thesuperzapper we have a way to fix that for you users too (and ours). I am going to update constraint and re-generate docker images with authlib=1.0.0 |
@potiuk actually the version would need to be the last But I think we may as well keep |
Right.... |
I will fix it though anyway. |
I prefer to get it "updated to latest authlib" in upcoming 2.3.3 (I hope we will upgrade to FAB 4 by then rather than break oauth for 2.2.5 - 2.3.2 users :) |
BTW. 2.2.4 and below had 0.15.5 |
@thesuperzapper - FYI: all constraints and images of Airlfow 2.2.5, 2.3.0, 2.3.1. 2.3.2 are refreshed now. |
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861 (cherry picked from commit 5674491)
the Thank you once more @thesuperzapper |
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861 (cherry picked from commit 5674491dc8e8ed1685cdb4c04922cb72ad8ba9b4) GitOrigin-RevId: 2a7c1f842407f815d8abe0d2239e64f317307439
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861 (cherry picked from commit 5674491dc8e8ed1685cdb4c04922cb72ad8ba9b4) GitOrigin-RevId: 2a7c1f842407f815d8abe0d2239e64f317307439
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861 GitOrigin-RevId: 5674491dc8e8ed1685cdb4c04922cb72ad8ba9b4
when i am using azure authentication in flask app builder getting this error : Error returning OAuth user info: %s 'upn' i have got jwt token credentials are verified but getting UPN key error how can i resolve it |
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861 (cherry picked from commit 5674491dc8e8ed1685cdb4c04922cb72ad8ba9b4) GitOrigin-RevId: 2a7c1f842407f815d8abe0d2239e64f317307439
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861 GitOrigin-RevId: 5674491dc8e8ed1685cdb4c04922cb72ad8ba9b4
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861 GitOrigin-RevId: 5674491dc8e8ed1685cdb4c04922cb72ad8ba9b4
Currently, we are restricting
Authlib
to<1.0.0
in our requirements, authlib has now released version 1.0.1 with lots of fixes and security patches, we should update our pin to allow 1.0.1.Lots of people have been inadvertently testing using 1.0.1 for us! This is because airflow forgot to pin
authlib
to the same versions asFlask-AppBuilder
, so the latestauthlib
is always installed with airflow.@potiuk you may want to look at that!
The main issues I see from people who have already tried to use 1.0.1, are related to
jwks_uri
not being set (rather than any actual issue with Flask-AppBuilder).The error text is:
Error authorizing OAuth access token: Missing "jwks_uri" in metadata
, see related issues:Currently, all of our OAUTH security examples don't show setting
jwks_uri
which is now required when usingid_token
auth.We need to update our examples to set
jwks_uri
so they continue to work withauthlib
1.0.1.Example for Google with
jwks_url
:We may also want to show setting
server_metadata_url
to an OpenID/.well-known/openid-configuration
URL, (which replaces the need to setauthorize_url
,access_token_url
, andjwks_uri
so is a bit easier for people).Example for Google with
server_metadata_url
:Example for Okta with
sever_metadata_url
:The text was updated successfully, but these errors were encountered: