elastic#10099 change from .bind to .on and remove unnecessary onKeyDo…

…wn call

src/ui/public/modals/__tests__/confirm_modal.js

@@ -184,9 +184,7 @@ describe('ui/modals/confirm_modal', function () {
         confirmButtonText: 'bye',
         onConfirm: confirmCallback,
         onCancel: cancelCallback,
-        onClose: closeCallback,
-        title: 'hi',
-        showClose: false
+        title: 'hi'
       };
 
       confirmModal('hi', confirmModalOptions);
@@ -203,18 +201,13 @@ describe('ui/modals/confirm_modal', function () {
         confirmButtonText: 'bye',
         onConfirm: confirmCallback,
         onCancel: cancelCallback,
-        onClose: closeCallback,
-        title: 'hi',
-        showClose: false
+        title: 'hi'
       };
 
       confirmModal('hi', confirmModalOptions);
 
       const e = angular.element.Event('keydown'); // eslint-disable-line new-cap
-      e.keyCode = 27;
-      while(e.keyCode === 27) {
-        e.keyCode = Math.floor((Math.random() * 100) + 1);
-      }
+      e.keyCode = 50;
       angular.element(document.body).trigger(e);
 
       expect(cancelCallback.called).to.be(false);

src/ui/public/modals/modal_overlay.html

@@ -1 +1 @@
-<div class="kuiModalOverlay" ng-keydown="onKeyDown($event)"></div>
+<div class="kuiModalOverlay"></div>

src/ui/public/modals/modal_overlay.js

@@ -9,13 +9,11 @@ export class ModalOverlay {
     this.overlayElement = angular.element(modalOverlayTemplate);
     this.overlayElement.append(modalElement);
 
-    const onKeyDown = (event) => {
+    angular.element(document.body).on('keydown', (event) => {
       if(event.keyCode === 27) {
         scope.onCancel();
       }
-    };
-
-    angular.element(document.body).bind('keydown', onKeyDown);
+    });
     angular.element(document.body).append(this.overlayElement);
   }