-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cell cycle correction #28
Comments
Hello - Glad you find the tool useful! The issue of cell cycle is a function of the dataset you are using. If you believe cell cycle does significantly impact your data, we do recommend corrected the cell cycle effects before using Palantir. The Anndata of Human CD34+ bone marrow cells is prior to cell cycle correction. In the manuscript, we use fscLVM to correct for the effects and found that correcting for cell cycle helped us align the start and precursors better. Wrt kNN, this is a bit unusual - could you please share the error if you are still facing the issue. |
Hello, To accept the future behavior, pass 'sort=False'. To retain the current behavior and silence the warning, pass 'sort=True'. sort=sort, Process finished with exit code 1 |
Oh, and I should mention that I also try to set the num_components in run_pca and run_diff_maps.
|
Sorry for the late response on this. I unfortunately cannot reproduce this error on my side. Do you by any chance have duplicate cell names? If not, do you mind anonymizing the data and sending the count matrix to us to debug? |
hi again, This is the code I run (sometimes it works, other times it fails and produces the error code - see end of message)
Error:
|
Thanks for the update. We will get back shortly! |
A fix related to [issue#28](#28). When identifying terminal states, duplicate values were generated instead of unique ones.
@ShobiStassen Thank you for reporting this. |
A fix related to [issue#28](dpeerlab#28). When identifying terminal states, duplicate values were generated instead of unique ones.
hi,
Firstly, Palantir is a really great tool. thanks for making it!
I was wondering if the input to Palantir is the cell-cycle corrected data?
Also, in the comparison of Palantir to other methods in your jupiter notebooks, does the input anndata file of Human CD34+ bone marrow cells (where X is filtered, normalized matrix) include cell cycle correction. If palantir does use cell cycle corrected data, how much does this impact the results?
also, on a separate note, for some reason I cannot get Palantir to run when k (in the NN-graph) is around 10-15knn. Palantir completes the 'run' even as low as knn=5, but something happens in the knn= 10-15 range. Is this something you have experienced? I can share some error messages after I test it out a bit more myself.
Thanks a ton
Shobi
The text was updated successfully, but these errors were encountered: