Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary "rawNonce" from FirebasePlugin.m #900

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

TheNotorius0
Copy link

@TheNotorius0 TheNotorius0 commented Oct 26, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

I had this pull request opened 6 months ago (#883) and unfortunately you merged a few days ago just when I was messing around with "rawNonce" on the Google Authentication for iOS, to test a few things.

You need this change, which basically reverts my pull request to the original state, otherwise the app crashes. The rawNonce is only used when logging in with Apple, as per the original pull request.

@dpa99c dpa99c merged commit 279f579 into dpa99c:master Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants