Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify plugin.xml #7

Merged
merged 1 commit into from
Jun 20, 2019
Merged

modify plugin.xml #7

merged 1 commit into from
Jun 20, 2019

Conversation

dann95
Copy link

@dann95 dann95 commented Jun 19, 2019

Autoident file and upgrade tags from "framework" to "pod", everytime i was trying to install, i received the message that "framework" was deprecated and will be removed soon, when i changed from the original plugin to this fork, the Podfile was always empty, and the build generates an error "could not find Firebase.h", upgrading to "pod" tag, it generates the Podfile normally and no build error. This may remove support to old versions, but at any time Cordova will finally remove the use of this tag.

@dann95
Copy link
Author

dann95 commented Jun 19, 2019

generated file with new tags in my mac OS:

platform :ios, '9.0'
use_frameworks!
target 'Myappname' do
	pod 'Firebase/Core', '5.15.0'
	pod 'Firebase/Auth', '5.15.0'
	pod 'Firebase/Messaging', '5.15.0'
	pod 'Firebase/Performance', '5.15.0'
	pod 'Firebase/RemoteConfig', '5.15.0'
	pod 'Fabric', '1.9.0'
	pod 'Crashlytics', '3.12.0'
end

generated file with previous tags in my mac OS:

platform :ios, '7.0'
target 'Myappname' do
end

@dpa99c
Copy link
Owner

dpa99c commented Jun 20, 2019

The <framework type="podspec"> is from the original PR which I merged to this fork (since it hasn't been merged to main cordova-plugin-firebase).
So replacing it with <pod> is fine since our fork of cordova-plugin-cocoapod-support supports it and parses it.
So this is good to merge.

@dpa99c dpa99c merged commit 61f4326 into dpa99c:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants