Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type for authenticateUserWithEmailAndPassword #686

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

tzappia
Copy link

@tzappia tzappia commented Nov 15, 2021

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

What is the purpose of this PR?

This PR adds a type for authenticateUserWithEmailAndPassword in index.d.ts. authenticateUserWithEmailAndPassword is an existing function that was missing from the types.

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

This PR does not change any functionality. It adds a missing type definition.

What testing has been done on existing functionality?

This PR does not change any functionality. It adds a missing type definition.

Other information

The changes in this PR have been used in a production app available on both the App Store and Google Play Store.

@dpa99c dpa99c changed the base branch from master to dev January 26, 2022 16:14
@dpa99c dpa99c merged commit 22d5815 into dpa99c:dev Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants