Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Android) Fix/Feat: Improved notification image support #667

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

ollm
Copy link

@ollm ollm commented Oct 4, 2021

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

Improved notification image support and fixed error that did not show the notification image when the app was in the foreground.

Fix: #202

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Tested with and without the new variables when the app is closed, in foreground and background in the Android Studio emulator.

What testing has been done on existing functionality?

Other information

@dpa99c dpa99c changed the base branch from master to dev January 26, 2022 16:05
@dpa99c dpa99c merged commit fb24e94 into dpa99c:dev Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] ANDROID Rich push notification image payload in foreground
2 participants