Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FirebaseFirestore pre-compiled pod #440

Closed
wants to merge 2 commits into from
Closed

use FirebaseFirestore pre-compiled pod #440

wants to merge 2 commits into from

Conversation

ovaris
Copy link

@ovaris ovaris commented Jun 29, 2020

Use pre-compiled version of Firebase Firestore pod to reduce build times on iOS.
Significantly reduces build times, please see https://github.com/invertase/firestore-ios-sdk-frameworks for further details!

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • [ x] Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • [x ] No

@ovaris
Copy link
Author

ovaris commented Jun 29, 2020

Hmm, noticed this isn't actually working:

pod install     
Analyzing dependencies
[!] There are multiple dependencies with different sources for `Firebase` in `Podfile`:

- Firebase/Core (= 6.23.0)
- Firebase/Auth (= 6.23.0)
- Firebase/Messaging (= 6.23.0)
- Firebase/Performance (= 6.23.0)
- Firebase/RemoteConfig (= 6.23.0)
- Firebase/Firestore (from `https://github.com/invertase/firestore-ios-sdk-frameworks.git`, tag `6.23.0`)

@dpa99c
Copy link
Owner

dpa99c commented Jun 29, 2020

Thanks, this is a good idea. I'll regression test when I get some time.

@ovaris
Copy link
Author

ovaris commented Jun 29, 2020

Fixed by updating pod name, also had to upgrade my cocoapods version from 1.8.X to 1.9.x, after that iOS project compiles without errors,

@dpa99c
Copy link
Owner

dpa99c commented Jun 30, 2020

I've tested this and it works great - brings my build time down from ~240s to ~60s.

However, as you say this requires [email protected] which is a breaking change.
So I'm wondering whether this justifies another major version bump or whether, since I've just bumped the major version to 10 for the Firebase Crashlytics migration, we just push it out in a patch/minor version release?

I'm also thinking to add a hook script to check the cocoapods version which will prevent lots of support issues being opened due to plugin users having old versions of cocoapods.

@dpa99c dpa99c closed this in 778d1d8 Jun 30, 2020
dpa99c pushed a commit that referenced this pull request Jun 30, 2020
…on and resolves #440.

BREAKING CHANGE: Requires cocoapods>=1.9 (previously cocoapods>=1.8).
Adds hook script to check local cocoapods version during plugin install.

# Conflicts:
#	plugin.xml
@dpa99c
Copy link
Owner

dpa99c commented Jun 30, 2020

I've published this in [email protected] - thanks again for the idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants