Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: (Android, iOS) Filters for firestore collection (Changed fetchFirestoreCollection method). #367

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

ianitsky
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

Added filters to collection, to download only necessary documents from firestore.

Does this PR introduce a breaking change?

  • Yes
  • No

fetchFirestoreCollection method need to be refactored in all app to add the filter argument. The filter value can be false or [] (Empty array) after collection name.

What testing has been done on the changes in the PR?

I tested in a working project and utilizing a page prepared to this test.

Other information

@ghost
Copy link

ghost commented Apr 14, 2020

Congratulations 🎉. DeepCode analyzed your code in 1.859 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

@dpa99c
Copy link
Owner

dpa99c commented Apr 16, 2020

Great, thanks for this PR.
I'll update the test project to illustrate the filters and this can go out in the next release.

@dpa99c dpa99c merged commit d5fc5ff into dpa99c:master Apr 16, 2020
@ianitsky ianitsky deleted the feature/firestoreFilters branch April 27, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants