Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local variable is accessed from within inner class #229

Merged
merged 1 commit into from
Nov 25, 2019
Merged

local variable is accessed from within inner class #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/android/FirebasePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ public void run() {
}

private void logError(final CallbackContext callbackContext, final JSONArray args) throws JSONException {
String message = args.getString(0);
final String message = args.getString(0);

cordova.getThreadPool().execute(new Runnable() {
public void run() {
Expand Down Expand Up @@ -908,7 +908,7 @@ private static String getPrivateField(PhoneAuthCredential credential, Field fiel
}
}

public void signInWithCredential(final CallbackContext callbackContext, JSONArray args){
public void signInWithCredential(final CallbackContext callbackContext, final JSONArray args){
cordova.getThreadPool().execute(new Runnable() {
public void run() {
try {
Expand Down Expand Up @@ -940,7 +940,7 @@ public void onComplete(@NonNull Task<AuthResult> task) {
});
}

public void linkUserWithCredential(final CallbackContext callbackContext, JSONArray args){
public void linkUserWithCredential(final CallbackContext callbackContext, final JSONArray args){
cordova.getThreadPool().execute(new Runnable() {
public void run() {
try {
Expand Down