Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setBadgeNumber() blocking UI on iOS #72

Closed
jeremycastelli opened this issue Aug 1, 2019 · 0 comments
Closed

setBadgeNumber() blocking UI on iOS #72

jeremycastelli opened this issue Aug 1, 2019 · 0 comments
Labels
bug Something isn't working properly

Comments

@jeremycastelli
Copy link

Hey !
First I want to thank you for the revival of this plugin. You have done a brilliant work ! Thank you !
I don't know if it's the responsability of the plugin or the firebase SDK, calling the methods get/setBadgeNumber() block the UI which become totally non responsive for about 5-10sec.
and here is what I have at the same time in Xcode's console

`

Main Thread Checker: UI API called on a background thread: -[UIApplication setApplicationIconBadgeNumber:]
PID: 9705, TID: 4399573, Thread name: (none), Queue name: com.apple.root.default-qos, QoS: 0
Backtrace:
4 Courseur 0x0000000104e3868c __33-[FirebasePlugin setBadgeNumber:]_block_invoke + 104
5 libdispatch.dylib 0x0000000105b736f0 _dispatch_call_block_and_release + 24
6 libdispatch.dylib 0x0000000105b74c74 _dispatch_client_callout + 16
7 libdispatch.dylib 0x0000000105b77ad4 _dispatch_queue_override_invoke + 876
8 libdispatch.dylib 0x0000000105b85dc8 _dispatch_root_queue_drain + 372
9 libdispatch.dylib 0x0000000105b867ac _dispatch_worker_thread2 + 156
10 libsystem_pthread.dylib 0x00000001c20f91b4 _pthread_wqthread + 464
11 libsystem_pthread.dylib 0x00000001c20fbcd4 start_wqthread + 4
2019-08-02 00:01:55.361908+0200 Courseur[9705:4399573] [reports] Main Thread Checker: UI API called on a background thread: -[UIApplication setApplicationIconBadgeNumber:]
PID: 9705, TID: 4399573, Thread name: (none), Queue name: com.apple.root.default-qos, QoS: 0
Backtrace:
4 Courseur 0x0000000104e3868c __33-[FirebasePlugin setBadgeNumber:]_block_invoke + 104
5 libdispatch.dylib 0x0000000105b736f0 _dispatch_call_block_and_release + 24
6 libdispatch.dylib 0x0000000105b74c74 _dispatch_client_callout + 16
7 libdispatch.dylib 0x0000000105b77ad4 _dispatch_queue_override_invoke + 876
8 libdispatch.dylib 0x0000000105b85dc8 _dispatch_root_queue_drain + 372
9 libdispatch.dylib 0x0000000105b867ac _dispatch_worker_thread2 + 156
10 libsystem_pthread.dylib 0x00000001c20f91b4 _pthread_wqthread + 464
11 libsystem_pthread.dylib 0x00000001c20fbcd4 start_wqthread + 4
`

any thoughts about this ?

Don't hesitate if you need more informations
Cheers

dpa99c pushed a commit that referenced this issue Aug 5, 2019
…turn an error (rather than attempting to grant permission again which causes issues - see �#72).
@dpa99c dpa99c added the bug Something isn't working properly label Aug 5, 2019
@dpa99c dpa99c closed this as completed in 83fb9c3 Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly
Projects
None yet
Development

No branches or pull requests

2 participants