Skip to content

Commit

Permalink
Patch version: 5.0.1
Browse files Browse the repository at this point in the history 
Set plist dependency to use fork which fixes bug causing #136 and #90.
Set xcode to @1.0.0 which is published from the new apache/cordova repo.
  • Loading branch information
@dpa99c
dpa99c committed Dec 18, 2017
1 parent e7d0b58 commit b3266d2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "5.0.0",
"version": "5.0.1",
"name": "cordova-custom-config",
"cordova_name": "cordova-custom-config",
"description": "Cordova/Phonegap plugin to update platform configuration files based on preferences and config-file data defined in config.xml.",
Expand Down Expand Up @@ -31,8 +31,8 @@
"dependencies": {
"lodash": "^4.3.0",
"elementtree": "^0.1.6",
"plist": "^2.1.0",
"xcode": "^0.9.3",
"plist": "xiangpingmeng/plist.js",

This comment has been minimized.

Sign in to view

Copy link
@devsheder

devsheder Dec 20, 2017

Hi, on my Project we are behind a corporate proxy and we canot use this version because of the dependency to https://github.com/xiangpingmeng/plist.js
Do you have an idea of when you'll fix that ?
Thanks

This comment has been minimized.

Sign in to view

Copy link
@dpa99c

dpa99c Dec 20, 2017

Author Owner

The problem is that the version of plist.js that's published to npm contains a bug (see #136) and no new versions have been published which fix that bug, hence the reliance on the forked version from @xiangpingmeng.
Until a new version of plist.js is published to npm in which this bug is fixed, then this plugin will need to remain dependent on the fork, otherwise it will suffer the consequences of the bug (i.e. it will cause corruption of iOS plist files).

This comment has been minimized.

Sign in to view

Copy link
@devsheder

devsheder Dec 20, 2017

Okay thanks for your response.
Did you ask to the plist developers to publish a new version to npm ?
Thx

This comment has been minimized.

Sign in to view

Copy link
@dpa99c

dpa99c Dec 20, 2017

Author Owner

No new version has been published in 8 months so I'm not that hopeful.
Here's the issue: TooTallNate/plist.js#79

This comment has been minimized.

Sign in to view

Copy link
@devsheder

devsheder Dec 20, 2017

Okay, thanks
"xcode": "^1.0.0",
"colors": "^1.1.2",
"shelljs": "^0.7.0",
"tostr": "^0.1.0"
Expand Down
2 changes: 1 addition & 1 deletion plugin.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
id="cordova-custom-config"
version="5.0.0">
version="5.0.1">

<name>cordova-custom-config</name>
<description>Cordova/Phonegap plugin to update platform configuration files based on preferences and config-file data defined in config.xml</description>
Expand Down

0 comments on commit b3266d2

Please sign in to comment.