Set highlightedIndex to defaultHighlightedIndex on input value change #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added some changes related to these highlighted indexes. Make sure to rebase and see that it works. I will try to help you as much as possible to get these changes in, as it will be a great improvement for our accessibility. Thanks again for contributing! |
|
Got it... I'll pull down the changes and confirm we're good to go. |
kilrain
force-pushed
the
highlightedIndex
branch
from
845a1ef to
352e490
Compare
|
@silviuavram My smoke testing worked as expected and all unit tests pass as well. |
silviuaavram
requested changes
Mar 2, 2019
kilrain
force-pushed
the
highlightedIndex
branch
from
352e490 to
61035a1
Compare
kilrain
force-pushed
the
highlightedIndex
branch
from
61035a1 to
c4ac3a5
Compare
|
Ok - change requests resolved. |
silviuaavram
approved these changes
Mar 9, 2019
|
🎉 This PR is included in version 3.2.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR ensures the highlightedIndex is reset to defaultHighlightedIndex when the inputValue is changed.
Why:
documented here: #664
How:
In both
inputHandleChangeandinputHandleTextChange, I included the following bit of state to update:I've also added a test and updated the docs to reflect this change.
Checklist:
Additionally,
setupscript which is documented in the feature request ticket.vscodeto.gitignore