Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undocumented suppressRefError prop #531

Merged
merged 2 commits into from
Jul 29, 2018

Conversation

jf248
Copy link
Contributor

@jf248 jf248 commented Jul 27, 2018

Fixes #529

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please add a test for this functionality? I'd hate to break it :)

@jf248
Copy link
Contributor Author

jf248 commented Jul 27, 2018

Test added :)
Btw I was getting a bunch of failing tests on the master branch all with this error:
SecurityError: localStorage is not available for opaque origins at Window.get localStorage...

I think it's because of an update to jest. Adding the below to a jest.config.js file passed all the tests again. Didn't add to PR because I thought you might want to make the change at the kcd-scripts level?

const {jest: jestConfig} = require('kcd-scripts/config')

module.exports = Object.assign(jestConfig, {
  testURL: "http://localhost/",
})

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! I think @alexandernanberg fixed the kcd-scripts issue.

@kentcdodds kentcdodds merged commit 96febd4 into downshift-js:master Jul 29, 2018
Rendez pushed a commit to Rendez/downshift that referenced this pull request Sep 30, 2018
* Add undocumented suppressRefError prop

* Add test for suppressRefError prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants