types: expand selectedItem to include null #1091
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Expands the type definition of
selectedItem
in both theuseSelect
anduseCombobox
interfaces so that TS developers can effectively control their downshift instance without having to suppress warnings and compilation errors.Note that this change isn't necessary (at least I don't think) for
useMultipleSelection
since passing an empty array effectively controls the Downshift.Why:
#1088
As per the docs,
selectedItem
can be either:Up to this point, that second state wasn't possible to achieve in TS land due to type errors.
How:
Expanded the type definition to include null.
Checklist:
I'm not sure which of these are applicable 🤔