[Typings] Field type missing from useCombobox / useSelect 's props.onStateChange

[andrei-datcu]

• downshift version: 5.2.0

Problem description:
According to the docs:

changes: These are the properties that actually have changed since the last state change. This also has a type property which you can learn more about in the stateChangeTypes section.

Yet in index.d.ts:

onStateChange?: (changes: Partial<UseComboboxState<Item>>) => void

export interface UseComboboxState<Item> {
  highlightedIndex: number
  selectedItem: Item
  isOpen: boolean
  inputValue: string
}

There's no type field

Suggested solution:
The field seems to be present for useMultipleSelection:

  onStateChange?: (changes: UseMultipleSelectionStateChange<Item>) => void

export interface UseMultipleSelectionStateChange<Item>
  extends Partial<UseMultipleSelectionState<Item>> {
  type: UseMultipleSelectionStateChangeTypes
}

So I guess creating two new interfaces that are extending the Use.*State interfaces seems the most consistent option.

[silviuaavram]

I took another look at #985 and I think it will fix this, am I right?

[kimroen]

I took another look at #985 and I think it will fix this, am I right?

Yes, I believe so!

[silviuaavram]

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀