Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed separator on windows for result.json #52

Merged
merged 1 commit into from
Apr 24, 2015

Conversation

gregorymaertens
Copy link
Contributor

To have each bundle into separate subfolders, it's currently possible to have such a thing having the bundle named like 'js/vendor'.
On windows there is an error where \ is used in the result.json file. E.g.
config.js:

    bundle : {
        'js/vendor' : {
            scripts : [
...

produces

  "js/vendor": {
    "scripts": "js\vendor-9de064e6.js"
  }

this PR covers this point. The unit test doesn't cover exactly the above case but uses the pathPrefix option for windows like separator.

@chmontgomery
Copy link
Contributor

Thanks for the PR! I'll review shortly

chmontgomery added a commit that referenced this pull request Apr 24, 2015
fixed separator on windows for result.json
@chmontgomery chmontgomery merged commit 27442c8 into dowjones:master Apr 24, 2015
@chmontgomery
Copy link
Contributor

published in v2.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants