Merge pull request sorbet#136 from stripe-internal/pt-KeepEmptyLinesA…

…tTheStartOfBlocks KeepEmptyLinesAtTheStartOfBlocks: false
dougedey-shopify · Nov 6, 2017 · 0fc49c9 · 0fc49c9
2 parents 2683b0f + 1bd5c7a
commit 0fc49c9
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 12 deletions.
diff --git a/.clang-format b/.clang-format
@@ -63,7 +63,7 @@ IndentWidth:     4
 IndentWrappedFunctionNames: false
 JavaScriptQuotes: Leave
 JavaScriptWrapImports: true
-KeepEmptyLinesAtTheStartOfBlocks: true
+KeepEmptyLinesAtTheStartOfBlocks: false
 MacroBlockBegin: ''
 MacroBlockEnd:   ''
 MaxEmptyLinesToKeep: 1

diff --git a/ast/Context.cc b/ast/Context.cc
@@ -484,7 +484,6 @@ NameRef GlobalState::enterNameUTF8(UTF8Desc nm) {
             swap(*(strings.end() - 1), *(strings.end() - 2));
         }
     } else {
-
         if (strings_last_page_used + nm.to > GlobalState::STRINGS_PAGE_SIZE) {
             strings.push_back(make_unique<vector<char>>(GlobalState::STRINGS_PAGE_SIZE));
             // printf("Wasted %i space\n", STRINGS_PAGE_SIZE - strings_last_page_used);

diff --git a/ast/TreeMap.h b/ast/TreeMap.h
@@ -297,7 +297,6 @@ template <class FUNC> class TreeMap {
         if (what == nullptr || dynamic_cast<EmptyTree *>(what) != nullptr || dynamic_cast<Nil *>(what) != nullptr)
             return what;
         if (ClassDef *v = dynamic_cast<ClassDef *>(what)) {
-
             if (HAS_MEMBER_preTransformClassDef<FUNC>::value) {
                 v = PostPonePreTransform_ClassDef<FUNC, HAS_MEMBER_preTransformClassDef<FUNC>::value>::call(ctx, v,
                                                                                                             func);

diff --git a/ast/Trees.cc b/ast/Trees.cc
@@ -152,7 +152,6 @@ void printArgs(GlobalState &gs, stringstream &buf, vector<unique_ptr<Expression>
 }
 
 string ConstDef::toString(GlobalState &gs, int tabs) {
-
     return "constdef " + this->symbol.info(gs, true).name.name(gs).toString(gs) + " = " +
            this->rhs->toString(gs, tabs + 1);
 }

diff --git a/ast/Trees.h b/ast/Trees.h
@@ -420,7 +420,6 @@ class InsSeq : public Expression {
 };
 
 class EmptyTree : public Expression {
-
     virtual std::string toString(GlobalState &gs, int tabs = 0);
     virtual std::string showRaw(GlobalState &gs, int tabs = 0);
     virtual std::string nodeName();

diff --git a/ast/Types.cc b/ast/Types.cc
@@ -206,7 +206,6 @@ shared_ptr<ruby_typer::ast::Type> ruby_typer::ast::Types::glb(ast::Context ctx,
 }
 
 bool isSubTypeGround(ast::Context ctx, shared_ptr<Type> &t1, shared_ptr<Type> &t2) {
-
     auto *g1 = dynamic_cast<GroundType *>(t1.get());
     auto *g2 = dynamic_cast<GroundType *>(t2.get());
 
@@ -407,7 +406,6 @@ shared_ptr<Type> OrType::getCallArgumentType(ast::Context ctx, ast::NameRef name
 
 shared_ptr<Type> AndType::dispatchCall(ast::Context ctx, ast::NameRef name, ast::Loc callLoc,
                                        vector<TypeAndOrigins> &args, shared_ptr<Type> fullType) {
-
     Error::notImplemented();
 }
 

diff --git a/common/os/linux.cc b/common/os/linux.cc
@@ -12,7 +12,6 @@ using namespace std;
 string exec(string cmd);
 
 string addr2line(const string program_name, void const *const *addr, int count) {
-
     auto addr2line_cmd = strprintf("atos -o %.256s", program_name.c_str());
     for (int i = 3; i < count; ++i) {
         addr2line_cmd = strprintf("%s %p", addr2line_cmd.c_str(), addr[i]);

diff --git a/common/os/mac.cc b/common/os/mac.cc
@@ -9,7 +9,6 @@ using namespace std;
 string exec(string cmd);
 
 string addr2line(const string program_name, void const *const *addr, int count) {
-
     auto addr2line_cmd = strprintf("atos -o %.256s", program_name.c_str());
     for (int i = 3; i < count; ++i) {
         addr2line_cmd = strprintf("%s %p", addr2line_cmd.c_str(), addr[i]);

diff --git a/common/typecase.h b/common/typecase.h
@@ -45,7 +45,6 @@ template <typename Base> void typecase(Base *b) {
 
 template <typename Base, typename FirstSubclass, typename... RestOfSubclasses>
 void typecase(Base *base, FirstSubclass &&first, RestOfSubclasses &&... rest) {
-
     using Signature = get_signature<FirstSubclass>;
     using Function = std::function<Signature>;
 

diff --git a/main/realmain.cc b/main/realmain.cc
@@ -224,7 +224,6 @@ int realmain(int argc, char **argv) {
         st.bytes += src.size();
         parse_and_print(gs, options, "-e", src, prints);
     } else {
-
         for (auto &fileName : files) {
             console->debug("Parsing {}...", fileName);
             string src;

diff --git a/test/test_corpus.cc b/test/test_corpus.cc
@@ -318,7 +318,6 @@ vector<Expectations> listDir(const char *name) {
     }
 
     while ((entry = readdir(dir)) != NULL) {
-
         if (entry->d_type == DT_DIR) {
             if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0)
                 continue;
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     string ConstDef::toString(GlobalState &gs, int tabs) {
         return "constdef " + this->symbol.info(gs, true).name.name(gs).toString(gs) + " = " +
                this->rhs->toString(gs, tabs + 1);
     }
@@ Expand Down @@