Qualify clause #344
Closed
Qualify clause #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/slessard/goqu
…com/slessard/goqu
…com/slessard/goqu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for feature request #343
As this is my first pull request for this project I need a little coaching. In order to actually use the new feature I had to rename the repository. This creates a huge number of changed files in this PR where the actual number of file changed to implement this feature is only 9. I didn't find any recommended solution for forking this repo and contributing a PR in a less noisy way.
In any case this PR adds support for the QUALIFY clause. The feature is off by default. I wrote some unit tests and even tested it against a Teradata database.