Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean expression alias #307

Merged

Conversation

XIELongDragon
Copy link
Contributor

so we can support

SELECT ("a" IS NULL) AS "x", ("b" > 2) AS "y" FROM t

@XIELongDragon
Copy link
Contributor Author

for 249

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #307 (bdb1c43) into master (a7630f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          62       62           
  Lines        3477     3478    +1     
=======================================
+ Hits         3369     3370    +1     
  Misses         92       92           
  Partials       16       16           
Flag Coverage Δ
unittests 96.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exp/exp.go 71.42% <ø> (ø)
exp/bool.go 93.33% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7630f7...bdb1c43. Read the comment docs.

@XIELongDragon XIELongDragon force-pushed the boolean_expression_alias branch from ace37b0 to fe98cb6 Compare October 10, 2021 02:46
@XIELongDragon XIELongDragon force-pushed the boolean_expression_alias branch from fe98cb6 to bdb1c43 Compare October 10, 2021 02:49
@doug-martin doug-martin changed the base branch from master to v9.18.0-rc October 16, 2021 21:23
@doug-martin doug-martin merged commit e6bf9c3 into doug-martin:v9.18.0-rc Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants