Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed several bugs in bluetoothscanner.html #381

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fixed several bugs in bluetoothscanner.html #381

merged 1 commit into from
Oct 6, 2022

Conversation

doudar
Copy link
Owner

@doudar doudar commented Oct 5, 2022

This should make the bluetoothscanner.html a little more intuitive to use.

Fixed:

  • Instances where many duplicates would be placed in the dropdowns.
  • Currently connected devices are now in the dropdowns and able to be saved.
  • Devices found while scanning will now be a the top of the boxes.
  • The active scan interval has been increased to increase connection chances.

doudar
doudar commented Oct 5, 2022
View reviewed changes
Copy link
Owner Author

@doudar doudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the files changed.

alexquilty
alexquilty reviewed Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@alexquilty alexquilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@doudar doudar merged commit d608dba into develop Oct 6, 2022
@doudar doudar deleted the Longer_scan branch October 6, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexquilty alexquilty alexquilty left review comments

@eMadman eMadman Awaiting requested review from eMadman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doudar @alexquilty