Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add new build target for reverse proxy in devcontainer #840

Merged

Conversation

ublefo
Copy link
Contributor

@ublefo ublefo commented May 3, 2024

Introduce a new configuration for serve and build to allow running frontend server on a different port in devcontainer, so this change can be seamless for people with existing devcontainer setups. This should also not affect anyone who aren't using the devcontainer in their development setup.

@jakerenzella
Copy link
Member

I want to test this before merging

@ublefo
Copy link
Contributor Author

ublefo commented May 5, 2024

Currently NODE_ENV is set to docker so these changes won't affect anything, if you set NODE_ENV to devcontainer the frontend will listen on port 4201, and API_URL will be set to ${window.location.origin}/api so the api requests will go to the reverse proxy too.

@ublefo ublefo force-pushed the devcontainer-reverse-proxy branch from b4679e4 to 65aaa93 Compare May 18, 2024 03:00
@jakerenzella jakerenzella merged commit 91bcf45 into doubtfire-lms:development May 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants