Fix: no auth method mailer #451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This change may require servers to set
DF_SMTP_AUTHENTICATIONtoplainas that was the previous default.Currently, mailer auth defaults to
plain.Some mailers don't rely on mailer auth, and instead use internal IP ranges.
No-auth method smtp relies on the lack of an auth key, and there is no valid value to default to.
The defaul plain method meant that non-auth mailers can't set the auth method correctly.
WARNING: This may require servers to set
DF_SMTP_AUTHENTICATIONtoplainas that was the previous default.